design-system-react icon indicating copy to clipboard operation
design-system-react copied to clipboard

Published 20 hours ago • verified publisher icon salesforce

Support menu item visible length in autocomplete combobox

Open interactivellama opened this issue 6 years ago • 1 comments

Currently in Combobox we have

	/**
	 * Determines the height of the menu based on SLDS CSS classes. This only applies to the readonly variant. This is a `number`.
	 */
	readOnlyMenuItemVisibleLength: PropTypes.oneOf([5, 7, 10]),

We should deprecated this property and make it menuItemVisibleLength and allow it to apply to autocomplete Comboboxes also.

Here is an example prop deprecation in App Launcher. https://github.com/salesforce/design-system-react/blob/master/components/app-launcher/index.jsx#L136

interactivellama avatar Oct 09 '19 15:10 interactivellama

@PaulaIoana This is probably the better path forward than the solution I mentioned in the meeting.

interactivellama avatar Oct 09 '19 15:10 interactivellama