Argus icon indicating copy to clipboard operation
Argus copied to clipboard

Long support 2

Open adelaidechambers opened this issue 7 years ago • 6 comments

Add support for long metric values and long trigger threshold values in Argus.

Note: This is essentially a copy of a previous PR to resolve CLA issue. I've copied comments from the previous PR over to keep track of them.

@colbyguan @pratiksha-shah @kgowdru @sundeepsf @rajsarkapally @dilipdevaraj-sfdc @nkunal

From the earlier PR:

Allow users to input metric data with long data values to Argus and long alert trigger threshold values. This way large values can be maintained precisely and triggers can be appropriately fired based off of these larger values.

adelaidechambers avatar Aug 16 '18 18:08 adelaidechambers

Kunal:

@kgowdru @adelaidechambers This is a fairly large change. We can continue with the review of this PR and incorporate feedback, but this should not get merged (and released) in our next release. Lets use this PR as an opportunity to come up with a set of integration/end-to-end/regression testing framework for Argus in general

adelaidechambers avatar Aug 16 '18 18:08 adelaidechambers

Dilip:

@adelaidechambers pls @mention reviewers so they can provide any review comments.

adelaidechambers avatar Aug 16 '18 18:08 adelaidechambers

Dilip:

@nkunal @colbyguan @sundeepsf @rajsarkapally @asinghsfdc Can you also pls review this PR, so @adelaidechambers can have sufficient time to incorporate feedback and do necessary testing. We can then make a call of how and when we want to deploy this feature change.

adelaidechambers avatar Aug 16 '18 18:08 adelaidechambers

Codecov Report

Merging #881 into develop will increase coverage by 0.5%. The diff coverage is 76.45%.

Impacted file tree graph

@@             Coverage Diff              @@
##             develop     #881     +/-   ##
============================================
+ Coverage      40.06%   40.56%   +0.5%     
- Complexity      2154     2217     +63     
============================================
  Files            316      317      +1     
  Lines          19164    19453    +289     
  Branches        2704     2750     +46     
============================================
+ Hits            7678     7892    +214     
- Misses         10445    10498     +53     
- Partials        1041     1063     +22
Impacted Files Coverage Δ Complexity Δ
...s/service/management/DefaultManagementService.java 19.46% <ø> (ø) 3 <0> (ø) :arrow_down:
...rvice/metric/transform/UnionValueUnionReducer.java 66.66% <ø> (ø) 2 <0> (ø) :arrow_down:
...m/salesforce/dva/argus/service/MonitorService.java 100% <ø> (ø) 0 <0> (ø) :arrow_down:
...rce/dva/argus/service/tsdb/DefaultTSDBService.java 15.38% <ø> (ø) 3 <0> (ø) :arrow_down:
...salesforce/dva/argus/service/DiscoveryService.java 79.16% <ø> (ø) 11 <0> (ø) :arrow_down:
...sform/AnomalyDetectionGaussianZScoreTransform.java 100% <ø> (ø) 4 <0> (ø) :arrow_down:
...esforce/dva/argus/ws/resources/AlertResources.java 0% <ø> (ø) 0 <0> (ø) :arrow_down:
...va/com/salesforce/dva/argus/sdk/entity/Metric.java 39.47% <ø> (ø) 10 <0> (ø) :arrow_down:
...form/AnomalyDetectionGaussianDensityTransform.java 100% <ø> (ø) 5 <0> (ø) :arrow_down:
.../service/metric/transform/DerivativeTransform.java 0% <0%> (ø) 0 <0> (ø) :arrow_down:
... and 75 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6a60d03...f03d0b4. Read the comment docs.

codecov-io avatar Aug 16 '18 20:08 codecov-io

@adelaidechambers BTW I think we should hold off on merging master into this branch until the very end, so as to not crowd the commits / introduce other authors into the PR.

colbyguan avatar Aug 17 '18 17:08 colbyguan

Thanks for the contribution! Unfortunately we can't verify the commit author(s): Adelaide Chambers <a***@s***.com>. One possible solution is to add that email to your GitHub account. Alternatively you can change your commits to another email and force push the change. After getting your commits associated with your GitHub account, refresh the status of this Pull Request.

salesforce-cla[bot] avatar Nov 10 '18 21:11 salesforce-cla[bot]