SmartProxy

SmartProxy copied to clipboard

Description

I usually use the Smart Proxy mode, and the Private Browsing Profile is set to Always Enable mode. After that, it seems that the websites opened with the middle button in the privacy window are not proxied.

Steps to Reproduce

1. use the Smart Proxy mode, and the Private Browsing Profile is set to Always Enable mode
2. open browser privacy window and search myip
3. middle-click on any website where you can view ip

Expected outcome: proxy server ip Actual outcome: actual ip

Which browsers did you test this on?

Firefox

Affected browser versions

116.0.3

Affected SmartProxy versions

1.3.0

Screenshots of the problems or steps to reproduce

No response

Any additional context

The same thing happens when using the right click to open a link in a new tab instead of using the middle button.

I don't see any issue, firefox reuses the connection from previous tabs to send new requests, maybe that's caused confusion in your end? Previous tabs might have connected differently.

Reopen this if you have more info to help reproducing the issue

Sorry for the late reply, but in step 3, if you use the left-click to open the page, you can see the proxy server ip.

I think on the same tab, using the left-click or the middle-click to open the page should be the same proxy setting.

@salarcode Sorry to keep bothering you with this.

I tried debugging the extension and found something that I don't know if it helps. It seems that when opening a link with the middle click, it will execute handleProxyRequest in ProxyEngineFirefox.ts once before calling TabManager to append the tabData, so the first time it executes handleProxyRequest, it can't find the tabData in TabManager.tabs, making it unable to set the Private Browsing Profile.

@salarcode Sorry to keep bothering you with this.

I tried debugging the extension and found something that I don't know if it helps. It seems that when opening a link with the middle click, it will execute handleProxyRequest in ProxyEngineFirefox.ts once before calling TabManager to append the tabData, so the first time it executes handleProxyRequest, it can't find the tabData in TabManager.tabs, making it unable to set the Private Browsing Profile.

Thanks, that might be a bug. I will check it later.

I found the issue with the incognito logic and it is resolved now. This also should work for incognito requests made by browser that are not associated with any tab.

Thank you for the detailed report