Saúl Ibarra Corretgé

Your code is broken and you seem to be trying to fix it in the wrong place, sorry. That said, we don't have good documentation on this so we might...

We currently don't specify what should happen after uv_stop, as in, will uv_run just continue happily ever after? Currently it doesn't, which might or might be unexpected. Given how long...

Thanks for getting the ball rolling? Maybe this can just be uv_reject?

> humble ping @saghul Done, sorry for the delay!

On the win side the big problem is you care closing the server handle, rather than the accepted connection. You need to peek into `handle->pipe.serv.pending_accepts` like you do for TCP.

> ```diff > + pipe_req = ((uv_pipe_t*)server)->pipe.serv.pending_accepts; > + CloseHandle(pipe_req->pipeHandle); > + pipe_req->pipeHandle = INVALID_HANDLE_VALUE; > ``` Don't you need to check if there are no pending pipe requests before...

Folks, rather than doing patches, can you provide a proper PR with all the changes? Maybe a new one is necessary if you are taking this over @huseyinacacak-janea . Or...

@huseyinacacak-janea Great work! Can you please rebase the branch?

Please take a look at the unresolved comments, we are close!

Windows 7 is no longer supported: https://github.com/libuv/libuv/blob/v1.x/SUPPORTED_PLATFORMS.md