Tobias Schmitz comments

Results 89 comments of


                                            Tobias Schmitz

Update to current krilla git version

Thanks @LaurenzV for bumping the `skrifa` crate. Now all remaining git dependencies should be fine.

refactor(git_tag,git_commit)!: Split off git_tag module from git_commit

Rebased onto master and formatted docs

Test runner changes

> One general remark is that it would be nice if you could add brief doc comments to at least all structs and ideally also methods. Done > Regarding merge:...

Test runner changes

The test suite might be a little bit slower now that svg and pdf are also tested and due to #7365. Running `cargo testit --stages=render,html,pdftags` should be just as fast...

Test runner changes

I think that should fix it

In pagebroken grid, second page is not after the (page) header

I'm not sure. I can see this being correct behavior, since the grid cell is broken across pages/columns, but still considered to be one logical part. There is a disconnect...

In pagebroken grid, second page is not after the (page) header

I agree that it feels somewhat inconsistent, and I definitely feel like there is room for improvement here, I'm just not sure what it should look like. The problem is...

In pagebroken grid, second page is not after the (page) header

> I think that page headers maybe end up in a similar situation where having them inside page body text would feel wrong. That's a good point, I think you're...

typst compiler crashed when it tries to `place` on a `margin: 0pt` and `width: auto` page _and_ the target format is PDF

I agree this should probably be handled by typst. The question is should this be an error in `typst-pdf` or should the error be generated for any paged document that...

Add support for unselectable text

> I'm not very familiar with accessibility best practices, but the two use cases I've seen (code block line numbers, watermarks) might both be considered artifacts. Perhaps we could automatically...