netbsd-curses icon indicating copy to clipboard operation
netbsd-curses copied to clipboard

Published 20 hours ago • verified publisher icon sabotage-linux

Heavy namespace violations in curses.h

Open richfelker opened this issue 5 years ago • 2 comments

curses.h is full of identifiers in the __-prefixed namespace, many of which are things that could easily clash with system headers. I saw a report of it failing to build on OSX that looked like it might have been related, and while I didn't see cause for that particular failure it prompted me to notice all these violations. I don't think any of them are essential/public API.

richfelker avatar May 13 '20 18:05 richfelker

@rsmarples could this be addressed in netbsd upstream ?

rofl0r avatar Jul 13 '20 16:07 rofl0r

Unlikely.

@richfelker is right that __ is reserved for system headers and in NetBSD curses.h is a system header and libcurses is a system library.

Saying that I'm always happy to make changes to make it more portable if there is a reported build failure, which there currently isn't.

rsmarples avatar Jul 13 '20 16:07 rsmarples