S5 icon indicating copy to clipboard operation
S5 copied to clipboard

Rename upload/directory to upload/app

Open pcfreak30 opened this issue 1 year ago • 4 comments

Given directory support is being/has been built, s5/upload/directory no longer makes sense for an app.

It should be s5/upload/app.

pcfreak30 avatar Jan 18 '24 18:01 pcfreak30

hello pcfreak30,

If the function behind "s5/upload/directory" doesn't change because I also upload directories. e.g.: cid.s5server.com/image/

and there are images from "1.jpg" to "100.jpg", which I can then access using cid and path to image. because I can get path via metadata. There is no "index.html" like in an app.

Whether it's called "s5/upload/directory" or "s5/upload/app" doesn't matter.

parajbs avatar Jan 18 '24 20:01 parajbs

hello pcfreak30,

If the function behind "s5/upload/directory" doesn't change because I also upload directories. e.g.: cid.s5server.com/image/

and there are images from "1.jpg" to "100.jpg", which I can then access using cid and path to image. because I can get path via metadata. There is no "index.html" like in an app.

Whether it's called "s5/upload/directory" or "s5/upload/app" doesn't matter.

If you want to use that endpoint to create a public directory, it does. Based on common sense, the name doesn't match the purpose/intent.

pcfreak30 avatar Jan 18 '24 20:01 pcfreak30

@pcfreak30 how would you feel about POST /s5/upload/webapp ?

redsolver avatar May 16 '24 11:05 redsolver

@redsolver That works. Just need to keep these distinct. Can add more endpoints as needed in the future too, like /media.

pcfreak30 avatar May 16 '24 11:05 pcfreak30