Ryan McDermott comments

Results 29 comments of


                                            Ryan McDermott

Want to translate to Arabic, Japanese, French, etc.?

@xavhan Great! Add another line in the _Translation_ section using the same format as the other languages listed.

Want to translate to Arabic, Japanese, French, etc.?

Thanks @raerpo!

Want to translate to Arabic, Japanese, French, etc.?

Excellent @7agustibm!

Want to translate to Arabic, Japanese, French, etc.?

No worries @fizzvr, thank you for your updates! That's wonderfu @7agustibm, take your time, I'm happy to approve a PR 🎉

ESLint

Good question! There are probably a few things on here that ESLint (or another static analysis tool) can take care of. It would be good to enumerate these. There are...

ESLint

@Glavin001 Nice job!

Change wording and add examples for Liskov Substitution Principle

Thanks for your expertise! You're right. Can you update your commit to not have the code example at the bottom. I like to keep the code examples only in a...

"Don't write to global functions" section improvement

We could change this whole subsection and use a better example. Thanks for bringing this up! If you have an idea that doesn't involve Array and Set diffing and is...

SRP example violates dependency inversion principle

Thanks you're right! Can you open a PR?

Make objects have private members better (?) example

@fesnt @DavidVujic Good points from you both. Both ways are valid, but there's some good arguments to be made about avoiding the `this` keyword when possible. It can cause whole...