pytorch_cluster
pytorch_cluster copied to clipboard
rusty1s
Enable returning distances from knn and knn_graph
TL;DR Add a switch for knn and knn_graph to enable returning distances alongside the edge_index.
This code has been tested on CPU and CUDA 11.3 with PyTorch 1.11.0 on Ubuntu 18.04.
Related: pyg-team/pytorch_geometric#3010
I still cannot directly decorate knn and knn_graph with @torch.jit.script per your suggestions (https://github.com/pyg-team/pytorch_geometric/issues/3010#issuecomment-1166582712). So I took a slightly different approach which was similar to https://github.com/pytorch/pytorch/issues/37986. Though @torch.jit.script has to be removed from the above two functions, the code that uses those two functions can be correctly jitted. Is it OK with you? @rusty1s
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
dbcafbe) 100.00% compared to head (a6a5aca) 100.00%. Report is 23 commits behind head on master.
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@ Coverage Diff @@
## master #133 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 9 9
Lines 77 116 +39
=========================================
+ Hits 77 116 +39
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
This pull request had no activity for 6 months. It will be closed in 2 weeks unless there is some new activity.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
This pull request had no activity for 6 months. It will be closed in 2 weeks unless there is some new activity.
This pull request had no activity for 6 months. It will be closed in 2 weeks unless there is some new activity.