llm icon indicating copy to clipboard operation
llm copied to clipboard

feat: introduce rust ci

Open odysa opened this issue 2 years ago • 6 comments

This PR adds a GitHub action to run build, test, and lint (Clippy) the code on every PR.

odysa avatar Mar 17 '23 00:03 odysa

Doesn't the build require LLVM? At least pre https://github.com/setzer22/llama-rs/pull/28 being merged I guess. Or at least that was my impression on trying it on windows a few hours ago.

darthdeus avatar Mar 17 '23 01:03 darthdeus

You're right - I keep getting got by that 😅

Let's see what @setzer22 thinks.

philpax avatar Mar 17 '23 07:03 philpax

You're right - I keep getting got by that sweat_smile

Let's see what @setzer22 thinks.

Yup, now that the bindgen dependency is gone, I think this CI workflow (plus my suggested change) for cargo fmt should work now. Is there a good way to tests this before merging?

setzer22 avatar Mar 17 '23 14:03 setzer22

You can see it running on @odysa's branch: https://github.com/odysa/llama-rs/actions/runs/4443013198/jobs/7799855788

Looks like it's failing due to #1. Can you pull in the latest ggml.c/h?

philpax avatar Mar 17 '23 14:03 philpax

Looks like a linking error happened on Ubuntu 22.04. 👀 https://github.com/odysa/llama-rs/actions/runs/4449174539

odysa avatar Mar 17 '23 16:03 odysa

Looks like a linking error happened on Ubuntu 22.04. 👀 https://github.com/odysa/llama-rs/actions/runs/4449174539

Yeah, that's #1. @setzer22's working on fixing that by updating to the latest ggml once they're free 🙏

philpax avatar Mar 17 '23 16:03 philpax

Made a few changes, everything seems to be working now :smile: Thanks a lot @odysa!

setzer22 avatar Mar 17 '23 19:03 setzer22