llm icon indicating copy to clipboard operation
llm copied to clipboard

Continuous integration

Open philpax opened this issue 2 years ago • 2 comments

It should be pretty straightforward to set up CI on [Windows|Linux|macOS] x86-64 and macOS ARM64. It should also help us test porting over the remaining build flags from the original Makefile.

philpax avatar Mar 16 '23 01:03 philpax

It will not be possible to run tests, however, because I don't think we can put the weights on the CI server. But still, something to just verify it compiles on multiple architectures would be pretty good already.

I generally also add clippy and rustfmt checks in my projects, but I'm open to be convinced otherwise. I'd say at least rustfmt is necessary. Too many people use format-on-save and it tends to ruin diffs if you don't enforce formatting on CI.

setzer22 avatar Mar 16 '23 10:03 setzer22

Yeah, compilation + clippy + rustfmt sounds good to me. We could potentially bake our own test tensors for the purposes of making sure it actually runs, but I'm not sure how involved that could be. Future project, I think!

philpax avatar Mar 16 '23 11:03 philpax