libc icon indicating copy to clipboard operation
libc copied to clipboard

Published 20 hours ago • verified publisher icon rust-lang

Support confstr on Linux

Open magicant opened this issue 1 year ago • 3 comments

This pull request adds support for the confstr function on Linux and also defines the constants used as a parameter for the function.

I moved the function declaration from src/unix/bsd/apple/mod.rs to src/unix/mod.rs (rather than adding to src/unix/linux_like/linux/mod.rs) since it is part of POSIX so it should be available on any unix-like systems.

The constants for non-linux targets are not the scope of this pull request.

magicant avatar Mar 05 '24 14:03 magicant

r? @JohnTitor

rustbot has assigned @JohnTitor. They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

rustbot avatar Mar 05 '24 14:03 rustbot

Pull request looks good to me. More comprehensive than #3771.

Maybe a main-branch-first approach is ideal?

jgarzik avatar Jul 13 '24 11:07 jgarzik

@magicant could you rebase this and target main?

This should remove confstr from src/unix/linux_like/linux/gnu/mod.rs, as was added in https://github.com/rust-lang/libc/pull/3771.

@rustbot author

tgross35 avatar Aug 16 '24 10:08 tgross35