compiler-builtins icon indicating copy to clipboard operation
compiler-builtins copied to clipboard

Why are files like absvdi2.c or absvsi2.c still compiled?

Open est31 opened this issue 7 years ago • 2 comments

According to the README, they are never called by LLVM and thus don't have to be implemented in Rust. But why is their C implementation being compiled?

est31 avatar Apr 15 '18 04:04 est31

While they are not called by LLVM, there are some builtins that are called by GCC-generated code. I haven't checked if this applies to these particular functions though.

IIRC this is mainly relevant when we are statically linking to GCC-generated C code, such as musl targets. I don't think we are linking to libgcc on those targets (maybe we should?).

Amanieu avatar Apr 15 '18 04:04 Amanieu

hmmm so this sort of gets into the terrirory of #217 ? Either way, I think we should either reimplement those files in Rust, or remove them. But keeping them around and requiring people to have a C compiler for that platform around is not nice :)

est31 avatar Apr 15 '18 04:04 est31