svd2rust icon indicating copy to clipboard operation
svd2rust copied to clipboard

Ship a 1.0 release

Open thejpster opened this issue 5 years ago • 4 comments

Part of https://github.com/rust-embedded/wg/issues/383

Blockers:

  • [ ] Add your blocking issues here

thejpster avatar Jan 07 '20 20:01 thejpster

I'd like to nominate https://github.com/rust-embedded/svd2rust/issues/213. I don't have the bandwidth to work on it, so if the powers that be decide it's not worth their time, that's fine. But I think it should be considered.

hannobraun avatar Jan 08 '20 06:01 hannobraun

Proposing a few things:

  • Document the safety guarantees provided by svd2rust PACs
  • Is write_with_zero safe regarding those guarantees? I think it can be used to write illegal values into registers with write constraints.
  • Consider using links = "device-peripherals" in the generated crate's manifest
  • Implement bare_metal::StaticResource for Peripherals (once a new version of bare-metal has been released)
  • Improve build times of generated code to the point where i.MX RT PACs can be generated in a reasonable time frame (I'd say something like 30 seconds on a system with 8 GB of RAM) – also consider tracking this in a similar manner to https://perf.rust-lang.org/ to catch regressions

jonas-schievink avatar Feb 09 '20 21:02 jonas-schievink

* Is `write_with_zero` safe regarding those guarantees? I think it can be used to write illegal values into registers with write constraints.

Good point. I missed this.

burrbull avatar Feb 10 '20 06:02 burrbull

Does the 1.0 backcompat guarantees apply to the generated PAC crates as well as svd2rust itself? If so, do we only care about backcompat for ARM PACs or for all architectures (MSP430, RISCV)?

YuhanLiin avatar Feb 13 '20 01:02 YuhanLiin