embedded-storage icon indicating copy to clipboard operation
embedded-storage copied to clipboard

Published 20 hours ago • verified publisher icon rust-embedded-community

Stronger focus on storage

Open Sympatron opened this issue 4 years ago • 0 comments

First off, I am glad this finally got it's own repository so progress can be made in this area.

I would vote to remove most of the traits currently in this crate or at least move them to a sub-module, because they are not directly related to storage.

  • BitSubset (almost) completely unrelated IMO.
  • I don't think Add<Address> should be implemented for Address. Semantically this makes no sense. Add<isize> and Sub<usize>/Sub<isize> would be useful on the other hand.
  • Region is related to storage, but I am not entirely convinced it has to be a trait, except you want to support disjoint regions?
  • I have to admit I don't fully understand the purpose of OverlapIterator, but I don't really see the value for users of this crate. Please correct me if I am wrong.

Sympatron avatar Dec 10 '20 15:12 Sympatron