rexpect icon indicating copy to clipboard operation
rexpect copied to clipboard

Migrate away from Error-Chain

Open 0xpr03 opened this issue 4 years ago • 5 comments

Error-Chain seems to be unmaintained or rather not developed any further. Furthermore most people start adopting failure,anyhow and eyre for new errors in applications, which require Sync on errors to allow easier multithreading. Currently error-chain can't and won't have sync errors, requiring some special handling for errors of this library. Thus I recommend migrating to thiserror.

See also https://github.com/rust-lang-nursery/error-chain/issues/240 and https://github.com/wisespace-io/pwned-rs/issues/4 for more info and an attached PR for how one can change this.

This is more or less in support of https://github.com/philippkeller/rexpect/pull/29

0xpr03 avatar Jan 28 '21 18:01 0xpr03

@0xpr03 this sounds good. Error-Chain seemed the best choice when I wrote this, but now there are better options.

As I'm currently "out of Rust", I won't implement this. So if you want you can migrate it over. If it passes tests and the example will still work, I'll merge it.

I guess it will also change the api, so I'll just bump the version to reflect this

philippkeller avatar Feb 05 '21 10:02 philippkeller

Isn't #29 exactly what we want then ?

0xpr03 avatar Apr 02 '21 09:04 0xpr03

ah yes, didn't realize this is the same error crate where we have the existing PR for. As I'm not into rust anymore, @0xpr03 would you like to have a look if the PR #29 is good? Unfortunately the contributer was not sure either as the person was new to Rust…

philippkeller avatar Apr 02 '21 11:04 philippkeller

Regarding maintainership you may want to add Rust Bus I'd also be willing to help out (which is how I started maintaining notify), but I'm probably not the most proficient with this project, just using it at work.

0xpr03 avatar Apr 02 '21 15:04 0xpr03

@0xpr03 thanks for pointing me to rust bus. I've invited rust bus as maintainer now, let's see what happens!

philippkeller avatar Apr 02 '21 15:04 philippkeller

Closed in #58

matthiasbeyer avatar Sep 12 '22 11:09 matthiasbeyer