gradle-doctor icon indicating copy to clipboard operation
gradle-doctor copied to clipboard

Published 20 hours ago • verified publisher icon runningcode

Implement Apple Rosetta translation check

Open GediminasZukas opened this issue 3 years ago • 1 comments

Solves: https://github.com/runningcode/gradle-doctor/issues/209

Used sysctl.proc_translated API via bash in order to determine if process is running under Rosetta or not according to documentation: https://developer.apple.com/documentation/apple-silicon/about-the-rosetta-translation-environment#Determine-Whether-Your-App-Is-Running-as-a-Translated-Binary

Additional related thought: maybe we need to make this check more generic and compare machine CPU architecture with running JDK target architecture? Something similar to: https://github.com/runningcode/gradle-doctor/issues/209#issuecomment-1132645634 As hardware for Windows or Linux may benefit from ARM architecture in the future as well (maybe already there is some variants in the market).

GediminasZukas avatar Jul 20 '22 09:07 GediminasZukas

Thanks for the ping. Running tests now.

runningcode avatar Aug 08 '22 09:08 runningcode

@runningcode, friendly ping. How we can proceed further with this change?

GediminasZukas avatar Jan 05 '23 09:01 GediminasZukas

Done!

GediminasZukas avatar Jan 06 '23 07:01 GediminasZukas

@runningcode, can we merge this?

GediminasZukas avatar Jan 17 '23 09:01 GediminasZukas