atlantis icon indicating copy to clipboard operation
atlantis copied to clipboard

Published 20 hours ago • verified publisher icon runatlantis

feat: add goss testing for the docker image

Open jippi opened this issue 1 year ago • 3 comments
trafficstars

what

Adding automatic testing for the container image to avoid regressions like #4439 and #4458

why

Testing is good

tests

Running the tests in CI

references

jippi avatar Apr 19 '24 13:04 jippi

This PR is up to date and ready for review/merge :)

jippi avatar Apr 25 '24 09:04 jippi

Anything blocking this from going in? It would have detected a pretty significant regression in Atlantis, and a nice corner stone for further verification of the container images we build down the road :)

jippi avatar May 07 '24 20:05 jippi

Anything blocking this from going in? It would have detected a pretty significant regression in Atlantis, and a nice corner stone for further verification of the container images we build down the road :)

time, is always time to review.

jamengual avatar May 07 '24 20:05 jamengual

@chenrui333 applied your suggested edits :)

jippi avatar May 19 '24 22:05 jippi