LlamaIndexTS icon indicating copy to clipboard operation
LlamaIndexTS copied to clipboard

feat: metadata filtering on simplevectorstore

Open swiecki opened this issue 1 year ago • 6 comments

a starting point for a potential implementation of metadata filtering on simple vector store

swiecki avatar Jan 31 '24 19:01 swiecki

⚠️ No Changeset found

Latest commit: ed30bee08a0d46bdeece744347ce49f5c265fa46

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Jan 31 '24 19:01 changeset-bot[bot]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
llama-index-ts-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 31, 2024 7:54pm

vercel[bot] avatar Jan 31 '24 19:01 vercel[bot]

I'm hoping someone can take this as a starting point and finish the implementation from here. Fair warning what is present here might be garbage relative to the standards you guys are looking for.

swiecki avatar Jan 31 '24 20:01 swiecki

@swiecki, that already looks very good! Great job, thanks a lot. Can you add a unit test and a changeset (just call pnpm changeset) - then I would be happy to merge it

marcusschiesser avatar Feb 01 '24 04:02 marcusschiesser

bump @swiecki

EmanuelCampos avatar Feb 08 '24 12:02 EmanuelCampos

metadataDict is used, but its:

  1. not defined
  2. never filled with content

sirpy avatar May 12 '24 08:05 sirpy

closing as metadatafilters are already implemented for SimpleVectorStore - for usage check https://github.com/run-llama/LlamaIndexTS/blob/main/examples/metadata-filter/simple.ts

marcusschiesser avatar Jul 26 '24 07:07 marcusschiesser