ri_cal

ri_cal copied to clipboard

Hi,

I found a minor bug where an extra colon was being inserted in x-property declarations when calendars are being written to string.

Instead of this:

X-WR-CALNAME:My calendar name

the gem was outputting this:

X-WR-CALNAME::My calendar name

I couldn't get the tests to run, but I think the test in the pull request is passing. :)

Thanks!

I'll look at it. I need to understand why it's putting the extra colon in, and whether there are other cases.

Thanks

On Sat, Dec 10, 2011 at 3:38 PM, Brent Miller < [email protected]

wrote:

Hi,

I found a minor bug where an extra colon was being inserted in x-property declarations when calendars are being written to string.

Instead of this:

X-WR-CALNAME:My calendar name

the gem was outputting this:

X-WR-CALNAME::My calendar name

I couldn't get the tests to run, but I think the test in the pull request is passing. :)

Thanks!

You can merge this Pull Request by running:

git pull https://github.com/foliosus/ri_cal master

Or you can view, comment on it, or merge it online at:

https://github.com/rubyredrick/ri_cal/pull/8

-- Commit Summary --

• Fix for extra colon at beginning of x-properties when written to string

-- File Changes --

M lib/ri_cal/component.rb (2) M spec/ri_cal/component_spec.rb (4)

-- Patch Links --

https://github.com/rubyredrick/ri_cal/pull/8.patch https://github.com/rubyredrick/ri_cal/pull/8.diff

---

Reply to this email directly or view it on GitHub: https://github.com/rubyredrick/ri_cal/pull/8

Rick DeNatale

Google+: +Rick DeNatale https://plus.google.com/102541178931067955550 Blog: http://talklikeaduck.denhaven2.com/ Github: http://github.com/rubyredrick Twitter: @RickDeNatale WWR: http://www.workingwithrails.com/person/9021-rick-denatale LinkedIn: http://www.linkedin.com/in/rickdenatale

Duplicate of https://github.com/rubyredrick/ri_cal/pull/5

I'm currently stumbling onto this bug, are there any plans of implementing this fix?

I also have the same issue. Are there any plans about merging this branch?