hyper-react icon indicating copy to clipboard operation
hyper-react copied to clipboard

calls to _react_param_conversion(json, validate_only) should pass both params

Open sollycatprint opened this issue 9 years ago • 0 comments

From @catmando on December 9, 2015 15:36

Currently some someplace is calling _react_param_conversion with only the first parameter (i.e. the second is being allowed to default)

But OPAL does not check for missing parameters.

So if you add self._react_param_conversion(json, validate_only) to a class without a default, there will be no warning, validate_only will get JS 'undefined' and your methods will not work correctly

Copied from original issue: zetachang/react.rb#94

sollycatprint avatar Jun 13 '16 13:06 sollycatprint