angular-gettext
angular-gettext copied to clipboard
rubenv
Directive doesn't need to be terminal anymore
One thing I'm wondering about: does terminal: true prevent the body from being parsed?
And if we turn it off: will it be parsed / compiled?
In the directive, we do $animate.leave(oldContents); immediately, so if we can avoid Angular.JS from processing the contents of the directive, all the better.
But maybe this is covered by priority? I'm not intimate with the deep internals of the Angular.JS compile loop to properly know the true impact of this.
This is why I didn't directly commit this patch ;)
I believe priority and terminal only relate to what happens when there are multiple directives on the same element. But I'm not an expert either.
This is the best explanation I've seen: http://stackoverflow.com/a/15266968
@rubenv @gabegorelick Is it going to to be merged? We've bumped into this as well.
