Ryan Christian

Results 483 comments of Ryan Christian

Isn't _necessarily_ needed. It's the output from the server build, used for prerendering. Some users do use this for SSR, so we cannot just delete it, nor do I think...

Jovi replied in the Preact issue, but thought I'd copy it here as well: https://github.com/preactjs/preact/issues/2564#issuecomment-636201423 Unpkg trips over a few different things today (as that comment provides links to) that...

> Another option could be for the libs to adopt a simpler package layout without nested `package.json` files and whatnot. While that was added before `"exports"` was (somewhat) standardized, it...

Yes, `isServer` is the one for prerendering. Regret it as in think it should change to something else? `isPrerender`?

Some still are or at least want to, but I've been dissuading. I'm somewhat partial to `isServer` as it doesn't really mean 'Server' as in 'SSR' (even if that's what...

@takurinton Hmm yeah that's a weird error in the CI. Will look into it. Not sure if it's unstable or just something odd has broken. Are you using 18 locally?...

Yeah that's the really weird error. Can't find the entry module, wonder if the resolution changed or something in Node 18. Thanks for the extra info, that help me later....

I'm not confident this is a test issue we can ignore. Earlier I misinterpreted one of our tests as being an error when it wasn't. Haven't used this in so...

Oh shoot. Yep, you're right. Sorry about that. I'll spend some time tracking this down when I can. Would like to cut a release afterwards but wouldn't want to do...

Seems pretty stable to me, see #938. Definitely not from the fetch impl