ngx-custom-validators icon indicating copy to clipboard operation
ngx-custom-validators copied to clipboard

Update to Angular 12

Open jsanta opened this issue 4 years ago • 7 comments

Updates version to support Angular 12. Just had to run:

  • npm install
  • npm audit fix
  • ng update @angular/core @angular/cli

jsanta avatar May 25 '21 20:05 jsanta

@jsanta Why don't you transfer all dependencies to peerDependencies? Wouldn't it be better to apply this instruction to move it to Ivy?

abadakhshan avatar Jun 06 '21 08:06 abadakhshan

@jsanta Why don't you transfer all dependencies to peerDependencies? Wouldn't it be better to apply this instruction to move it to Ivy?

You're welcome to fork my fork and apply those changes (that's the beauty of open source you know) 🙂

jsanta avatar Jun 26 '21 11:06 jsanta

Please support angular 12 soon

quanghd96 avatar Jun 29 '21 06:06 quanghd96

@jsanta Why don't you transfer all dependencies to peerDependencies? Wouldn't it be better to apply this instruction to move it to Ivy?

You're welcome to fork my fork and apply those changes (that's the beauty of open source you know) 🙂

I Created this and use https://www.npmjs.com/package/@narik/custom-validators

abadakhshan avatar Jul 01 '21 13:07 abadakhshan

@rsaenen Could you please merge? @abadakhshan Would you mind create a separate Github repo so we can work on and make PRs without this Narik thing? Further, I dont like that you take @rsaenen project and put your name in front. You renamed CustomFormsModule to NarikCustomValidatorsModule...

MickL avatar Nov 05 '21 12:11 MickL

@MickL There isn't any dependency on other Narik modules, but you are right. If it is a separate repository it could be better for contributors. I will do it ASAP.

What is your point about Module's name? I have noticed in Readme that it is a fork from @rsaenen repo.

abadakhshan avatar Nov 05 '21 12:11 abadakhshan

@MickL

I created a separate repo for it and publish version 7.0.1 to be compatible with Angular 13

https://github.com/NarikMe/narik-custom-validators

abadakhshan avatar Nov 05 '21 17:11 abadakhshan