ros2_control
ros2_control copied to clipboard
ros-controls
Handle HW errors on read and write in CM by stopping controllers (backport #742) #abi-breaking
This is an automatic backport of pull request #742 done by Mergify.
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refreshwill re-evaluate the rules@Mergifyio rebasewill rebase this PR on its base branch@Mergifyio updatewill merge the base branch into this PR@Mergifyio backport <destination>will backport this PR on<destination>branch
Additionally, on Mergify dashboard you can:
- look at your merge queues
- generate the Mergify configuration with the config editor.
Finally, you can contact us on https://mergify.com
![mergify[bot] avatar](https://avatars.githubusercontent.com/in/10562?v=4 "Published by a pub.dev verified publisher"){kind=small}
On a scale of 1-10 how much would that bother you? We'd really like to have this in Humble as it's a good quality of life improvement
I would like to have this feature in humble even with breaking abi check. My understanding of this breaking abi could be resolved by updating/fixing the relevant code after it is merged to humble. Is my understanding correct?
I would like to have this feature in humble even with breaking abi check. My understanding of this breaking abi could be resolved by updating/fixing the relevant code after it is merged to humble. Is my understanding correct?
You don't even need to fix the code, but just re-link your libraries. Basically, "recompile" it, beucase compiling and linking is merged togeather with colcon
I see. In this case, I think having this feature available in humble (current LTS release) is an easy decision and a clear winner over holding it. What do you think?
Could the reviewers give this a look and drop your feedback for not approving it?
Hello @bmagyar and @destogl. I hope you are well
We are using the ros2_control in the ROS Humble version in our project and are facing a problem that the modification in https://github.com/ros-controls/ros2_control/pull/742 will solve. Unfortunately, we can not upgrade our system for the last ROS 2 stable release. Hence, we need this feature in the Humble version.
Therefore, do you have some schedule estimation of when this backporting will occur? While this does not happen, do you have any suggestions on how we can handle the hardware component read/write failure for now?
In addition, I am available to help you if necessary!
A little complicated to get there but we are making strides
On Tue, 14 Nov 2023, 07:32 mergify[bot], @.***> wrote:
This pull request is in conflict. Could you fix it @mergify https://github.com/mergify[bot]?
— Reply to this email directly, view it on GitHub https://github.com/ros-controls/ros2_control/pull/838#issuecomment-1809674783, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA24PYJ4YPU2RC5Y4YUCVLDYEMM7PAVCNFSM6AAAAAARF7RPUGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMBZGY3TINZYGM . You are receiving this because you were mentioned.Message ID: @.***>
This pull request is in conflict. Could you fix it @bmagyar @destogl @christophfroehlich?
It is too late to merge this PR to Humble at this stage. That being said, we now support building the master branch from source on Humble so you can have this and even more features!