tools icon indicating copy to clipboard operation
tools copied to clipboard

Published 20 hours ago • verified publisher icon rome

JSON Formatting

Open MichaReiser opened this issue 3 years ago • 7 comments
trafficstars

Goal

Support formatting JSON documents

Tasks

  • [x] Literal formatting
  • [ ] Object formatting
  • [ ] Array formatting

(No comments, yay)

MichaReiser avatar May 10 '22 07:05 MichaReiser

This issue is stale because it has been open 14 days with no activity.

github-actions[bot] avatar Sep 21 '22 12:09 github-actions[bot]

Hi @MichaReiser I have been reading rome codebase for 2 weeks now. Can I work on this?

dhrjarun avatar Nov 11 '22 12:11 dhrjarun

Hi @MichaReiser I have been reading rome codebase for 2 weeks now. Can I work on this?

Not yet. The JSON parser isn't implemented yet, and there's some infrastructure that must be set up. I'll be working on the JSON parsing in the next few weeks, hopefully, it will be ready by December to start implementing JSON formatting.

MichaReiser avatar Nov 11 '22 13:11 MichaReiser

ok, let me know if I could be of any help in implementing JSON parsing.

dhrjarun avatar Nov 11 '22 13:11 dhrjarun

Hi @MichaReiser I have been reading rome codebase for 2 weeks now. Can I work on this?

@dhrjarun: @denbezrukov is setting up the test infra in #3913 and you could implement array formatting after that PR lands (and @denbezrukov could work on objects)

MichaReiser avatar Dec 02 '22 12:12 MichaReiser

Hi @MichaReiser I have been reading rome codebase for 2 weeks now. Can I work on this?

@dhrjarun: @denbezrukov is setting up the test infra in #3913 and you could implement array formatting after that PR lands (and @denbezrukov could work on objects)

Sure

dhrjarun avatar Dec 02 '22 12:12 dhrjarun

And #3913 is merged. Thank you @denbezrukov for your amazing work

MichaReiser avatar Dec 02 '22 15:12 MichaReiser