Rohit Gupta comments

Results 47 comments of


                                            Rohit Gupta

Copy PL folder in to LAI folder

qq: why haven't you moved them?

Add argument inference_grad_mode to Trainer

> I am fine with either since it's completely related to LM but trainer is the one that calls it.

Add argument inference_grad_mode to Trainer

@rschireman go ahead!

Fix type hints of tuner/batch_size_scaling.py

> > @otaj mind checking out... 🦦 > > I think that this is currently blocked by #11089 - and since that one is not merged yet, this cannot be...

Add ColossalAI strategy

hey @ver217 @1SAA Great work here so far. I think we are close. Can you fix the missing imports? Then we can check it on the CI. Currently there's an...

okay.. looks like colossalai tests are not running and are skipped since it's not being installed on the CI. Installation instructions are here: `pip install colossalai==0.1.10+torch1.12cu11.3`. @1SAA can you add...

[BUG] Check group is not getting the configured CI statuses

thank you, @tianhaoz95 for the update!

Weaviate Hybrid Search doesn't return source

I don't like this about weaviate sdk. For now you can specify source here: ```py WeaviateHybridSearchRetriever(..., attributes=['source']) ``` but then this is not very reliable and won't even work when...

Issues in framework affecting autoscaling

yeah , there's a PR already on the platform side to resolve List and Dict structures.

catching also PL deprecation warnigs

to just catch the deprecation warnings as an error, we need to somehow catch [LightningDeprecationWarning](https://github.com/PyTorchLightning/pytorch-lightning/blob/5914fb748fb53d826ab337fc2484feab9883a104/pytorch_lightning/utilities/warnings.py#L42-L43) from pytorch-lightning. Just like: https://github.com/PyTorchLightning/pytorch-lightning/blob/00d1758bac69d55e934e43f3961ba328a2b8951e/setup.cfg#L27-L29 but here pytorch-lightning is an external package, so we need...