Roch Devost
Roch Devost
@jamiehodge Looks like tests are still failing.
> Yes, I wasn't able to figure out how to require the versioned "mariadb/callback" ("mariadb" returns the promise api). That would be with ```require(`../../../versions/mariadb@${version}`).get('mariadb/callback')```.
@jamiehodge Thanks for all the work in this PR. We are refactoring our plugins right now to make them simpler and I took the opportunity to move the code from...
Is there any way to test for the side effects that the current approach could cause to avoid regressions in the future? cc @juan-fernandez
Should this be closed now that `pprof` was moved out?
> I'm not entirely sure how to write unit tests here There is tooling in place to test compatibility with external modules like this. Basically you would have to edit...
> On the other, it's a little counterintuitive that the Parent span finishes before all of Child's resolvers have finished. Additionally, the Query resolver doesn't respect this same convention. This...
> any suggestion regarding the node-ext and upstream koa failures? Is my setup wrong? For upstream `koa` they are also failing on `master` so you can ignore them. For `next`...
@flovilmart The events that are needed are basically: * **start:** When the operation starts, which would usually be when the function from the public API is called. We need this...
@flovilmart The context is never activated in the current implementation, unlike [http](https://github.com/DataDog/dd-trace-js/blob/2ca997c93838eba0c24ccb7a0bc171c43d41d10b/packages/datadog-plugin-http/src/client.js#L76), so any child of `undici` would end up in a different context. Since this is a client, it's...