kube-capacity icon indicating copy to clipboard operation
kube-capacity copied to clipboard

Published 20 hours ago • verified publisher icon robscott

incorrect memory value then memory specified in decimal format

Open cloud-66 opened this issue 3 years ago • 1 comments
trafficstars

bug #66 appears then memory request\limit specified in decimal format, so i think if we make format according typeResource everythink will be ok. But there are a few comments

  1. Request\Limits will be converted to BinarySi формат
  2. formatToMegiBytes function rounds up, not is the best way in all situation. Fore example 128M = 122,0703125 Mi , but function rounds it to 123Mi

before request memory = 128M limit memory = 512M image )

after request memory = 128M limit memory = 512M image )

cloud-66 avatar Jul 17 '22 12:07 cloud-66

@robscott hello, can you please take a look on this PR ?

cloud-66 avatar Jul 25 '22 16:07 cloud-66

We are hitting this issue as well. Too many zero's to parse for my human brain :)

buckleyGI avatar Nov 09 '22 09:11 buckleyGI

Sorry for the delay on this! Thanks for the fix @cloud-66!

robscott avatar Jan 19 '23 06:01 robscott