SeleniumLibrary

SeleniumLibrary copied to clipboard

This is a change that enables switching among multiple open browsers when executing this type of test scenarios. This is particularly important when there are multiple parallel sessions (e.g. automating a scenario where multiple users are logged in in an application and they have to interact).

Would it make more sense to have the newly added functionality behind a toggle ?

In other words add an argument that the user can choose to do these steps on switching browsers? I think yes. This one in particular gives me hesitation in that it forces the user to do these steps without asking. One can do this already with existing keywords. This is just a convenience that although helpful forces everyone to follow this action as currently implemented.

As I did a quick review of the open pull requests, this is one I was leaning towards rejecting because (1) it forces people to do steps they might not want to do (2) it adds to the overall keyword count when it can be done with existing keywords (3) I am not sure how widely needed or requested it is (again given it can be done with existing keywords).

As I did a quick review of the open pull requests, this is one I was leaning towards rejecting because (1) it forces people to do steps they might not want to do (2) it adds to the overall keyword count when it can be done with existing keywords (3) I am not sure how widely needed or requested it is (again given it can be done with existing keywords).

My Pov: Either have this sort of extra functionality behind a optional keyword argument or move the functionality to separate plugin - seleniumtestability definitely could take this - but even there, it would be good to be behind feature flag ..