HackerNewsReader icon indicating copy to clipboard operation
HackerNewsReader copied to clipboard

Crash when opening a Hacker News comment link

Open saagarjha opened this issue 8 years ago • 2 comments

I'm getting a crash (on a fresh copy built from source) when tapping on a link in the comments that leads to another comment (e.g. something like https://news.ycombinator.com/item?id=10313519). Here's the console output I get:

2017-01-02 12:21:52.161 HackerNewsReader[16004:213228] Nodes was nil.
2017-01-02 12:21:52.162 HackerNewsReader[16004:213228] Nodes was nil.
2017-01-02 12:21:52.164 HackerNewsReader[16004:213228] *** Assertion failure in -[HNFeedParser postFromTitleNode:detailNode:rank:queries:], /Users/saagarjha/Downloads/HackerNewsReader/HackerNewsReader/Classes/Networking/HNFeedParser.m:46
2017-01-02 12:21:52.168 HackerNewsReader[16004:213228] *** Terminating app due to uncaught exception 'NSInternalInconsistencyException', reason: 'Invalid parameter not satisfying: titleNode != nil'
*** First throw call stack:
(
	0   CoreFoundation                      0x00000001083d1d4b __exceptionPreprocess + 171
	1   libobjc.A.dylib                     0x0000000107e3321e objc_exception_throw + 48
	2   CoreFoundation                      0x00000001083d5e42 +[NSException raise:format:arguments:] + 98
	3   Foundation                          0x00000001079c866d -[NSAssertionHandler handleFailureInMethod:object:file:lineNumber:description:] + 195
	4   HackerNewsReader                    0x0000000106ffb2f5 -[HNFeedParser postFromTitleNode:detailNode:rank:queries:] + 405
	5   HackerNewsReader                    0x0000000106fe47ca -[HNPageParser parseDataFromResponse:queries:] + 970
	6   HackerNewsReader                    0x0000000107004ec1 __37-[HNDataCoordinator fetchWithParams:]_block_invoke_2 + 561
	7   HackerNewsReader                    0x0000000106fe8aee __40-[HNService fetchParameters:completion:]_block_invoke + 158
	8   HackerNewsReader                    0x0000000106fe9483 __54-[HNService performRequest:withParameters:completion:]_block_invoke.77 + 243
	9   CFNetwork                           0x000000010ab7dccc __75-[__NSURLSessionLocal taskForClass:request:uploadFile:bodyData:completion:]_block_invoke + 19
	10  CFNetwork                           0x000000010ab7d578 __49-[__NSCFLocalSessionTask _task_onqueue_didFinish]_block_invoke + 308
	11  Foundation                          0x00000001079359ad __NSBLOCKOPERATION_IS_CALLING_OUT_TO_A_BLOCK__ + 7
	12  Foundation                          0x000000010793568f -[NSBlockOperation main] + 101
	13  Foundation                          0x0000000107933d8c -[__NSOperationInternal _start:] + 672
	14  Foundation                          0x000000010792fccf __NSOQSchedule_f + 201
	15  libdispatch.dylib                   0x000000010bbb00cd _dispatch_client_callout + 8
	16  libdispatch.dylib                   0x000000010bb8de17 _dispatch_queue_serial_drain + 236
	17  libdispatch.dylib                   0x000000010bb8eb4b _dispatch_queue_invoke + 1073
	18  libdispatch.dylib                   0x000000010bb91385 _dispatch_root_queue_drain + 720
	19  libdispatch.dylib                   0x000000010bb91059 _dispatch_worker_thread3 + 123
	20  libsystem_pthread.dylib             0x000000010bf5f712 _pthread_wqthread + 1299
	21  libsystem_pthread.dylib             0x000000010bf5f1ed start_wqthread + 13
)
libc++abi.dylib: terminating with uncaught exception of type NSException

Since this doesn't happen in the App Store version, I'm guessing that one of the Pods broke something when it updated.

saagarjha avatar Jan 02 '17 20:01 saagarjha

Is this crash in simulator and device

dkhamsing avatar Jan 02 '17 21:01 dkhamsing

@dkhamsing Yes, this occurs in both the simulator and on a real device.

saagarjha avatar Jan 02 '17 23:01 saagarjha