Rano | Ranadeep

All the tasks are finished. Does that make this tracking issue finished too?

@seanchen1991 we can close this now, right?

closed by #1109

Hey @tropicaldog, thanks for your interest. > Does this means we need to also store the ConsensusState to the validation context? We don't modify the store in the validation step....

I think #1074 was a duplicate of this. If that is the case, we can close this after fixing this title.

Thanks for your PR, @hoank101 ! But this issue is a bit nuanced, and my suggestion on the issue ~is~ was misleading. `is_active` call on unstored `client_id` will return `Frozen`...

Note how it's being handled in ibc-go [here](https://github.com/cosmos/ibc-go/blob/c3ba0d03a99965471cd2a3c0ff0bd16875eeca78/modules/core/02-client/keeper/client.go#L37-L43). The status is checked after the consensus state is stored. But in ibc-rs, we separate _validation_ and _execution_. If we followed ibc-go,...

Let's merge this only after informalsystems/basecoin-rs#141 is merged.

This raises a question to me, do we really need to hardcode constants such as this, https://github.com/cosmos/ibc-rs/blob/4a0990f35e2a9338b7205445b9d21a044784104c/ibc-clients/ics07-tendermint/types/src/client_state.rs#L27 as they can be retrieved by `ToProto::type_url()` even in current codebase. For example,...

Actually, we don't need ``` impl Protobuf for DomainType {} ``` The compilation error source, after removing these https://github.com/cosmos/ibc-rs/blob/4a0990f35e2a9338b7205445b9d21a044784104c/ibc-clients/ics07-tendermint/src/consensus_state.rs#L96 https://github.com/cosmos/ibc-rs/blob/4a0990f35e2a9338b7205445b9d21a044784104c/ibc-testkit/src/testapp/ibc/clients/mock/consensus_state.rs#L103 can be refactored as ```rs use ibc::primitives::ToVec; Any::from(self).to_vec() ```