pytorch-fm icon indicating copy to clipboard operation
pytorch-fm copied to clipboard

Published 20 hours ago • verified publisher icon rixwew

But in layers.cpp

Open erlebach opened this issue 3 years ago • 0 comments

Hi,

In layer.py, class FeaturesEmbedding, one finds the line

self.offsets = np.array(0, *np.cumsum(field_dims)[:-1]), dtype=np.long)

My code generates an error. I replaced np.array by torch.tensor and np.cumsum by torch.cumsum , and the code works.

I believe the code as it is has a bug, which was fixed with my change. Could you please confirm this? I am not sure how the code can work as is. thanks.

erlebach avatar Aug 07 '22 03:08 erlebach