eigenvectors-from-eigenvalues icon indicating copy to clipboard operation
eigenvectors-from-eigenvalues copied to clipboard

benchmark with scipy or numpy implementation?

Open Xiaojieqiu opened this issue 5 years ago • 3 comments

Hey @ritchieng thanks for implementing this method so quickly! I am curious about the performance of this method comparing to other standard methods, implemented in scipy or numpy. Is it possible for us to see some benchmarking regarding this implementation?

Xiaojieqiu avatar Nov 19 '19 03:11 Xiaojieqiu

Hi @Xiaojieqiu, this should be easy. I'll provide a comparison of NumPy vs PyTorch by this week.

For large matrices, I would say a highly optimized PyTorch version (JIT and CUDA) would be very fast because you can run many function calls in parallel on the GPU and once you compile the function, you don't need the Python interpreter on subsequent calls. This will be implemented https://github.com/ritchieng/eigenvectors-from-eigenvalues/issues/2

ritchieng avatar Nov 19 '19 03:11 ritchieng

that will be wonderful, I am looking forward to seeing those benchmarks

Xiaojieqiu avatar Nov 19 '19 04:11 Xiaojieqiu

any progress??

hypnopump avatar Jan 26 '21 10:01 hypnopump