Rudi Grinberg
Rudi Grinberg
The code for downloading/extracting diffs isn't going to be shared, so in this case, removal should work. Is there a reason why the entire modules can't be just removed? Or...
You can either just revert all of our changes to opam related to this feature or continue along with this PR and remove the code altogether. Both are fine with...
From a first glance, it sounds like a reasonable request. Though I have no idea how a potential feature that addresses this problem might even look like. cc @snowleopard
Can you add a test case reproducing bug in a separate PR?
I remember this being discussed in the team meeting. The verdict was: all paths passed in the command line should be interpreted to relative to CWD
> The first part is to restrict this feature so it can only be used by dune itself as we agreed we did not want to make it public or...
With the env stanza, you can set it for entire directories. Either one works fine though
> I modified the stanza to scan the whole project except for the given dirs to exclude. I added `bench/` for now but if you can think of other dirs...
No, we don't want to vendor anything for libraries that we publish.
> Update the CI builds to include a check that ppx/ is always kept up to date. You can make it part of the `@check` alias for development and a...