AgentGPT icon indicating copy to clipboard operation
AgentGPT copied to clipboard

feat: add combobox for model names

Open Jshen123 opened this issue 2 years ago • 8 comments

Description: Editable Combobox for model name image

Jshen123 avatar Apr 14 '23 06:04 Jshen123

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
agent-gpt ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 15, 2023 6:45pm

vercel[bot] avatar Apr 14 '23 06:04 vercel[bot]

@awtkns , this PR will also resolve https://github.com/reworkd/AgentGPT/issues/98

Jshen123 avatar Apr 14 '23 06:04 Jshen123

Ideally we want to use something this for form elements like this. They are unstyled but implement things like keyboard nav etc..

awtkns avatar Apr 14 '23 06:04 awtkns

@Jshen123 It would also be good to give the option to input something that is not there :)

We can however merge this and improve after. up to you

awtkns avatar Apr 14 '23 06:04 awtkns

@Jshen123 It would also be good to give the option to input something that is not there :)

We can however merge this and improve after. up to you

Hey @awtkns, I like the added flexibility. I have opened another PR that merges into this one with the editable option (https://github.com/reworkd/AgentGPT/pull/115) image

tbh, I can see upside in both. @asim-shrestha what do you think?

Jshen123 avatar Apr 14 '23 09:04 Jshen123

Ideally we want to use something this for form elements like this. They are unstyled but implement things like keyboard nav etc..

good call! we should definitely address accessibility in a later PR

Jshen123 avatar Apr 14 '23 09:04 Jshen123

Hi @awtkns merged in editable combobox PR! ready for PR to main ✅

Jshen123 avatar Apr 15 '23 01:04 Jshen123

@Jshen123 seems there are some merge conflicts

awtkns avatar Apr 15 '23 04:04 awtkns

@Jshen123 seems there are some merge conflicts

Resolved!

Jshen123 avatar Apr 15 '23 17:04 Jshen123