revite icon indicating copy to clipboard operation
revite copied to clipboard

feat: use appropriate placeholder text when changing password

Open LedaThemis opened this issue 3 years ago • 2 comments

Please make sure to check the following tasks before opening and submitting a PR

  • [x] I understand and have followed the contribution guide
  • [x] I have tested my changes locally and they are working as intended
  • [x] These changes do not have any notable side effects on other Revolt projects
  • [x] (optional) I have opened a pull request on the translation repository
  • [x] I have included screenshots to demonstrate my changes

Closes #273

Before: before image

After: after image

LedaThemis avatar Jun 05 '22 22:06 LedaThemis

Conflicts with master, not sure if anything broke from a glance.

insertish avatar Jun 14 '22 14:06 insertish

Conflicts with master, not sure if anything broke from a glance.

The cause seems to be #650, specifically 41e533a (#650) (ModifyAccount.tsx) and 68b9d5e (#650) (FormField.tsx)

LedaThemis avatar Jun 14 '22 14:06 LedaThemis

Conflicting. Closing due to rewrite, https://github.com/revoltchat/frontend.

insertish avatar Jan 24 '23 17:01 insertish