revite icon indicating copy to clipboard operation
revite copied to clipboard

Published 20 hours ago • verified publisher icon revoltchat

Theme shop: Put creator in i18n string as field

Open Fuzuki785 opened this issue 3 years ago • 2 comments

Please make sure to check the following tasks before opening and submitting a PR

  • [x] I understand and have followed the contribution guide
  • [ ] I have tested my changes locally and they are working as intended
  • [x] These changes do not have any notable side effects on other Revolt projects
  • [x] (optional) I have opened a pull request on the translation repository
  • [ ] I have included screenshots to demonstrate my changes

Point 2: Discover doesn't load in dev mode (yarn dev) Point 4: Paired with https://github.com/revoltchat/translations/pull/25 Point 5: See point 2, also not really a visible change…

Fuzuki785 avatar Jan 18 '22 00:01 Fuzuki785

As far as I can tell, the theme shop has been removed in favour of simply using Discovery - is this still needed?

Rexogamer avatar Jan 20 '22 00:01 Rexogamer

As far as I could see, this is still what's used to render the themes page in discovery. Same element layout and the creator CSS class.

Fuzuki785 avatar Jan 20 '22 09:01 Fuzuki785

Closing due to rewrite, https://github.com/revoltchat/frontend. This is also still redundant I think?

insertish avatar Jan 24 '23 18:01 insertish