responsively-app icon indicating copy to clipboard operation
responsively-app copied to clipboard

Links that open in new tab are ignored/handed off to Chrome

Open Sub-Xaero opened this issue 4 years ago • 3 comments

🐞 bug report

✍️ Description

I am aware that the app does not yet support tabs (#215), but the app also just completely ignores a[target="_blank"]. I would have thought that the app could at least open those links in the same tab.

Repeated clicking of the link also seems to open a new tab in an instance of Chrome, rather than in Responsively itself.

🕵🏼‍♂️ Is this a regression?

This is the first time I've used Responsively. I couldn't say.

🔬 Minimal Reproduction

Visit a page that has a link with [target="_blank"], click the link.

🌍 Your Environment

Windows 10 - Build 19043.1083
Responsively v0.17.0
Google Chrome 91.0.4472.124 (Official Build) (64-bit) (cohort: stable_gradual_rollout)

🔥 Exception or Error or Screenshot

N/A

Sub-Xaero avatar Jul 13 '21 10:07 Sub-Xaero

Hey @Sub-Xaero :wave:,

Thank you for opening an issue. We will get back to you as soon as we can. Have you seen our Open Collective page? Please consider contributing financially to our project. This will help us involve more contributors and get to issues like yours faster.

https://opencollective.com/responsively

We offer priority support for all financial contributors. Don't forget to add priority label once you become one! :smile:

thanks @Sub-Xaero for reporting this

The expected behavior is to open a new window displaying the href (if it is a valid website url) or open the file if it is a local file and you are browsing on localhost. The fallback to all of this is to let the OS handle it, that's why you see Chrome open (I think we can improve the way URLs are validated, because if chrome can open it, we can too)

That worked for some time, but now I see that it doesn't (at least for some devices)

https://user-images.githubusercontent.com/13673443/125442165-9812daf1-96fc-4d17-b51a-e5367e4cb8ea.mp4

jjavierdguezas avatar Jul 13 '21 11:07 jjavierdguezas

Makes sense. Thank you for looking into it @jjavierdguezas . The provided video matches my experience of the bug, I failed to pick up in my initial report that the behaviour was different depending which device the event was initiated from.

Sub-Xaero avatar Jul 13 '21 11:07 Sub-Xaero