gsee icon indicating copy to clipboard operation
gsee copied to clipboard

Azimuth correction for hemisphere is not clear from docstrings

Open rabwent11 opened this issue 5 years ago • 0 comments

In pv.py >> def run_model(...) docstring: "Azimuth angle (degrees, 180 = towards equator)".

In trigon.py >> aperture_irradiance(..) docstring:
"0 = towards pole, going clockwise, 3.14 = towards equator."

In trigon.py >> aperture_irradiance(..) lines 230-231, correction is made by rotating azimuth clockwise by pi if lat in southern hemisphere:

if coords[0] < 0:
    azimuth = azimuth + np.pi

Docstrings could be updated to say "Azimuth angle (degrees, 180 = South)" and "0 = towards North, going clockwise, 3.14 = towards South."

rabwent11 avatar Jun 03 '20 10:06 rabwent11