Rémi
Rémi
@luckyb56, I'm all for it, but I would like to get some feedback from @oncletom on this one. I also opened another PR #128 to propose a possible new set...
@nmargaritis @oncletom Should we close this issue, as this is expected behavior?
@nmargaritis From what I understood, the rule from public suffix is `*.er`, which means that `google.er` is a valid public suffix, hence `isValid` returns `true` for `shop.google.er`.
tldjs.getDomain('acc1sub1-dot-moisestest.appspot.com') returns 'acc1sub1-dot-moisestest.appspot.com'
Hi @mbelchin, Thanks for reaching out! I get slightly different results for this domain (with latest version of the rules): ```js > tldjs.parse('acc1sub1-dot-moisestest.appspot.com') { hostname: 'acc1sub1-dot-moisestest.appspot.com', isValid: true, isIp: false,...
tldjs.getDomain('acc1sub1-dot-moisestest.appspot.com') returns 'acc1sub1-dot-moisestest.appspot.com'
@mbelchin Right, I think the "trick" works for a slightly different use-case. If you would try to parse `appspot.com`, then `publicSuffix` would be `appspot.com` and `domain` would be empty. In...
Hi @critsmet, I believe you might need to run this command after installing your dependencies in your staging and production environment as well (the command might need to be executed...
Hi @LesBarstow and thanks for the great feedback! It's really interesting to get another perspective. I would like to add the following, which is just my opinion on the matter....
Hi @taskinosman, thank you for your input. I proposed a solution a few weeks ago in the form of an option to enable a "lenient mode" for hostname validation in...
Hi @oncletom, thanks for initiating the discussion, and sorry for taking so long to give feedback on this! I really like that you identify the different use-cases for tld.js. In...
@oncletom I'm willing to help here. If we put up a list of projects in some meta-issue, we can share the work. I think it's a good idea! Should "collecting...