remix icon indicating copy to clipboard operation
remix copied to clipboard

fix(remix-cloudflare-pages): don't clone request

Open stepri opened this issue 3 years ago • 8 comments

Closes: #2195

#- [X] Docs #- [X] Tests

stepri avatar Mar 08 '22 21:03 stepri

Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳

remix-cla-bot[bot] avatar Mar 08 '22 21:03 remix-cla-bot[bot]

Not quite sure this will work. Instead, I think we should add .clone() here.

GregBrimble avatar Mar 27 '22 16:03 GregBrimble

Looks like it was intentionally removed by @jacob-ebey quite recently to fix some other bug that I don't know enough about.

GregBrimble avatar Mar 27 '22 17:03 GregBrimble

@GregBrimble You mentioned the other PR. Does that also fix the problem you wanted to solve with this PR? If so, please close this PR & #2195.

MichaelDeBoey avatar Mar 27 '22 18:03 MichaelDeBoey

@MichaelDeBoey , no. @jacob-ebey's commit introduced the bug #2195. But I don't know enough about why that work was done to know how to fix it.

Happy to put up a PR to re-add the .clone(), but I imagine y'all probably want some other solution?

GregBrimble avatar Mar 27 '22 20:03 GregBrimble

Hi, thankfully just found this issue/PR after having thought this was an error on my side. May I ask if there are any updates on this? I'm forced to use javascript-only Forms in my Remix+CF Pages project as a workaround now, which isn't ideal really.

3x071c avatar Mar 29 '22 21:03 3x071c

@stepri Is this PR ready for review?

MichaelDeBoey avatar Jun 04 '22 12:06 MichaelDeBoey

@MichaelDeBoey I'm not fully aware of the consequences of this PR, so that's why is still a draft. If someone likes to finish this PR, go ahead. :)

stepri avatar Jun 07 '22 08:06 stepri

@stepri Mind addressing @jacob-ebey's feedback? We can get this merged after that's done.

chaance avatar Feb 09 '23 13:02 chaance

This PR has been automatically closed because we haven't received a response from the original author 🙈. This automation helps keep the issue tracker clean from PRs that are unactionable. Please reach out if you have more information for us! 🙂

github-actions[bot] avatar Feb 19 '23 13:02 github-actions[bot]