remix
remix copied to clipboard
fix(remix-cloudflare-pages): don't clone request
Closes: #2195
#- [X] Docs #- [X] Tests
Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳
Not quite sure this will work. Instead, I think we should add .clone() here.
Looks like it was intentionally removed by @jacob-ebey quite recently to fix some other bug that I don't know enough about.
@GregBrimble You mentioned the other PR. Does that also fix the problem you wanted to solve with this PR? If so, please close this PR & #2195.
@MichaelDeBoey , no. @jacob-ebey's commit introduced the bug #2195. But I don't know enough about why that work was done to know how to fix it.
Happy to put up a PR to re-add the .clone(), but I imagine y'all probably want some other solution?
Hi, thankfully just found this issue/PR after having thought this was an error on my side. May I ask if there are any updates on this? I'm forced to use javascript-only Forms in my Remix+CF Pages project as a workaround now, which isn't ideal really.
@stepri Is this PR ready for review?
@MichaelDeBoey I'm not fully aware of the consequences of this PR, so that's why is still a draft. If someone likes to finish this PR, go ahead. :)
@stepri Mind addressing @jacob-ebey's feedback? We can get this merged after that's done.
This PR has been automatically closed because we haven't received a response from the original author 🙈. This automation helps keep the issue tracker clean from PRs that are unactionable. Please reach out if you have more information for us! 🙂