reflex-dom icon indicating copy to clipboard operation
reflex-dom copied to clipboard

Published 20 hours ago • verified publisher icon reflex-frp

Add DomHasCallStack for ghcjs-dom debug feature

Open hamishmack opened this issue 7 years ago • 4 comments
trafficstars

https://github.com/ghcjs/ghcjs-dom/blob/master/README.md#debug

hamishmack avatar Mar 13 '18 13:03 hamishmack

Pending performance testing.

ali-abrar avatar Mar 16 '18 17:03 ali-abrar

Per https://github.com/ghcjs/ghcjs-dom/blob/master/README.md#adding-domhascallstack-constraint there should be no performance issues when that library doesn't have debugging. So maybe this is good and we just need to change reflex platform to make sure that flag is off in release builds?

Ericson2314 avatar Dec 12 '19 22:12 Ericson2314

https://github.com/ghcjs/ghcjs-dom/blob/master/ghcjs-dom/ghcjs-dom.cabal#L28 at least currently, it's off by default.

Ericson2314 avatar Dec 12 '19 22:12 Ericson2314

There are other things to worry about, though. "Debug levels" are rarely composable, and debugging a library and debugging something using a library is rather different.

It's not clear how this stuff works with reflex, but I trust @hamishmack to have tried it out and gotten value :).

Ericson2314 avatar Dec 12 '19 22:12 Ericson2314