patch

patch copied to clipboard

alexfmpe

Getting rid of `Data.Monoid.DecidablyEmpty`

6

There's a comment at the top of `Data.Monoid.DecidablyEmpty` which reads: `-- TODO upstream somwhere else?` That "somewhere else" already exists: [`Data.Monoid.Null`](https://hackage.haskell.org/package/monoid-subclasses-1.1.3/docs/Data-Monoid-Null.html) from [`monoid-subclasses`](https://hackage.haskell.org/package/monoid-subclasses). I had a look at the instances...

endgame

Use of (lawless) Group/monoid-subclasses/InverseSemigroup in view

9

Continuing https://github.com/Taneb/groups/issues/7#issuecomment-1006968329 in a more appropriate place: Context: `patch` currently provides (but does not directly use) a `Group` class with lawless `instance (Ord k, Group g) => Group (MonoidalMap k...

endgame

From a discussion with a colleague, the following class emerged: ```haskell -- | Law: applyAlways (diff x y) x = y class Patch p => Diff p where -- |...

endgame

WIP: Combination of #1 and #2

2

Credit to @xplat for the heterogeneous patch idea for use with dmap.

Ericson2314

Get rid of Group, with the intention that the groups library is used instead

1

See change log, this does depend on https://github.com/reflex-frp/patch/issues/4 being resolved first, and possibly other issues.

Ericson2314

WIP: patch maps better

2

From https://github.com/reflex-frp/reflex/pull/328 CC @treeowl

Ericson2314

Use Group from elsewhere

15

We should find an existing library for this

Ericson2314

Giving `Identity` *meaning* just seems wrong: it should just get the underlying patch instance if it does anything at all. Worse, one cannot define the associated semigroup. `First` however already...

Ericson2314

WIP: Patch dmap reset and patchable

1

from https://github.com/reflex-frp/reflex/pull/357 CC @danbornside

Ericson2314