bootstrap-markdown

bootstrap-markdown copied to clipboard

I create this Pull Request because there are some styles that not supported by bootstrap-4. I Found it when use this lib on my project :smile: This is based on #213

Fixes:

• [x] Update bootstrap in bower.json
• [x] Change default icon to fa not glyph
• [x] Change btn class style

does this affect BS3?

Yes of course, in BS4 btn-default is replaced by btn-secondary and in BS4 glyph is not supported again, so I change the default icon to font-awesome. Do you mind if I add font-awesome in bower.json?

I meant what will happen for those who are still in BS3? We want to support BS4 but we don't want to ditch BS3 support e.g. by changing btn-default to btn-secondary.

Perhaps I'm missing something? @acrobat any thoughts?

Okay I add the btn-default again, I test it in my project again, and luckily it is not problem if we make the class like this

<button class="btn-default btn-secondary btn-sm">

I have try it use BS3 and BS4 and it work like this:

• If we use BS3 the style for the button is from btn-default
• And if we use BS4 the style for the button is from btn-secondary

This is the pict when I use BS3

---

And this one when I use BS4

Thanks @awebr000 ! @lodev09 @acrobat Thought on this? I think i'm gonna start to split the development branches into v2.x and this can be a baseline for v3.x branch - which happens to be a master at this point.

@toopay yep I think that's the best way to handle the new bootstrap 4 like you did on previous versions :)

@toopay where is toopay? i can't wait this for bs4 , git new branch bs4 for this feature

Bs4 beta was dropped a few hours ago

Preview option does not work, is it just me?

This looks good. Will try to pull and test this one.

A bit late on the show, but here are some thought.

@waggyman @lodev09 If you want to support BS3 and BS4 (which you should since a lot of us didn't switch yet), then you shouldn't delete the glyph icons completely, as can be seen on this line. I agree to change the default to "fa" but removing the glyph icon names entirely is a mistake since it could break some people's editor if they choose to keep the glyph as their default. Also, your bower file is quite outdated now on the dependencies side of it "bootstrap": "v4.0.0-alpha.6"

@niknokseyer I saw the "Preview" as broken too, then I found here that we can replace the parser with our own and that is what I did to fix mine.

$('textarea').markdown({
  parser: convertFunction, // or whatever
});

Any news here? I'm also interested by the bs4 support, is there something missing to merge this?