redis-io icon indicating copy to clipboard operation
redis-io copied to clipboard

CSS issue in headings

Open philraj opened this issue 7 years ago • 3 comments

image

There's an issue with the hover state of headings where the anchor that appears is clipped by the overflow: hidden defined on articles.

philraj avatar Aug 02 '18 18:08 philraj

It has been over 3 years. @djanowski apologies for pinging you like this, but will a PR for this issue be accepted?

KartikSoneji avatar Oct 07 '21 21:10 KartikSoneji

Hi @KartikSoneji - we'd appreciate you submitting a PR that resolves this issue (regrettably, my CSS skills lacking).

itamarhaber avatar Oct 09 '21 15:10 itamarhaber

I have opened a PR: #254

https://github.com/redis/redis-io/blob/8584b92cdf7ddf82db02764353011507a20002d0/public/styles.css#L215 https://github.com/redis/redis-io/blob/8584b92cdf7ddf82db02764353011507a20002d0/public/styles.css#L232

The issue is article and @media only screen and (min-width: 992px) article set overflow: hidden. I am not sure what it does, but the site looks the exact same to me without it.

Also, *zoom: 1; is a hack for targeting IE 5.5, IE6, and IE7, I am not sure we need it anymore.

KartikSoneji avatar Oct 11 '21 20:10 KartikSoneji