yaml-language-server icon indicating copy to clipboard operation
yaml-language-server copied to clipboard

Rewrite tests to use local schemas

Open evidolob opened this issue 4 years ago • 3 comments

Is your enhancement related to a problem? Please describe.

Some tests uses direct URI to schemas on schema store, and schemas may change which leads to test fail.

Describe the solution you would like

Use only local(static) schemas for tests.

evidolob avatar May 21 '21 08:05 evidolob

If schemas change would that break users too?

joshuawilson avatar May 21 '21 16:05 joshuawilson

No, it can and did break tests. By design tests should run in controlled environment, in general it is not good idea to depend on resources which we not control.

evidolob avatar May 21 '21 16:05 evidolob

@evidolob while I was trying to pickup the fix for the failure for this I noticed that I can not rebase parser-switch to master/main anymore.

gorkem avatar Jun 11 '21 17:06 gorkem