vscode-yaml icon indicating copy to clipboard operation
vscode-yaml copied to clipboard

Published 20 hours ago • verified publisher icon redhat-developer

Fix signature of ExtensionAPI.requestSchemaContent

Open schrej opened this issue 3 years ago • 1 comments

What does this PR do?

Changes the signature of ExtensionAPI.requestSchemaContent to include Promise<string> as a return value since the internal interface and the implementation supports it.

It's not that relevant, but makes it more obvious to users that this is an option.

schrej avatar Sep 13 '22 22:09 schrej

Is that macos test a flake?

schrej avatar Sep 19 '22 08:09 schrej

Seems like it is not a flake but I can not repro locally. @odockal any ideas?

gorkem avatar Sep 25 '22 20:09 gorkem

It was a flake, sometimes they are caused by problems with runners images and takes longer to fix.

ssbarnea avatar Oct 11 '22 09:10 ssbarnea