devconsole-operator
devconsole-operator copied to clipboard
redhat-developer
Fix install_devconsole for mac.
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: To fully approve this pull request, please assign additional approvers. We suggest the following additional approver: sbose78
If they are not already assigned, you can assign the PR to them by writing /assign @sbose78 in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
Hi @pmacik. Thanks for your PR.
I'm waiting for a redhat-developer member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
sbose-mac:hack sbose$ ./install_devconsole/consoledeveloper.sh
error: the path "./yamls/unmanage.yaml" does not exist
deployment.extensions/console-operator scaled
deployment.extensions/console scaled
error: the path "./yamls/redeploy-console-operator.yaml" does not exist
@sbose78 I've just tried in the macos (in VBox) and it works:
ibm-p8-kvm-03-guest-02:hack pmacik$ head -n 10 install_devconsole/consoledeveloper.sh
#!/bin/bash
set -x
function pathname() {
DIR="${1%/*}"
(cd "$DIR" && echo "$(pwd -P)")
}
cd $(pathname $0)
oc apply -f ./yamls/unmanage.yaml
ibm-p8-kvm-03-guest-02:hack pmacik$ ./install_devconsole/consoledeveloper.sh
++ pathname ./install_devconsole/consoledeveloper.sh
++ DIR=./install_devconsole
++ cd ./install_devconsole
+++ pwd -P
++ echo /Users/pmacik/Downloads/devconsole-operator-fix-install-devconsole-mac/hack/install_devconsole
+ cd /Users/pmacik/Downloads/devconsole-operator-fix-install-devconsole-mac/hack/install_devconsole
+ oc apply -f ./yamls/unmanage.yaml
clusterversion.config.openshift.io/version unchanged
...
Are you sure you tried it with the patch? :)