ofrak icon indicating copy to clipboard operation
ofrak copied to clipboard

Ensure no missing pip dependencies in `build_image.py`

Open ANogin opened this issue 3 years ago • 3 comments

One sentence summary of this PR (This should go in the CHANGELOG!) This changes the make install/make develop step of the finish.Dockerfile to run with network disabled, which means that any missing dependencies that were not properly installed in base.Dockerfile result in a build failure and flagged.

Link to Related Issue(s) Would enable detecting things like #419 would be detected by CI. This depends on #571 fixing #419 (until that is fixed, this change would break the build - will keep it in draft state until then).

Please describe the changes in your request. See summary.

Anyone you think should look at this, specifically? @whyitfor

ANogin avatar Feb 09 '23 07:02 ANogin

@whyitfor could we please land this one and use the new option in our CI? As I am working on #416 and #417 I am went to go back to this manually to make sure all the dependencies across ofrak components are consistent (only remembered to do it because I saw the docker build output for #417 and noticed it's uninstalling/reinstalling some packages in weird way in make develop) - and now discovering that even the main branch has incorrectly specified dependencies (will fill in separate PRs on those)?

ANogin avatar Feb 12 '24 03:02 ANogin